tispark icon indicating copy to clipboard operation
tispark copied to clipboard

support Spark3.3

Open qidi1 opened this issue 2 years ago • 36 comments

What problem does this PR solve?

support spark 3.3

What is changed and how it works?

  1. Add spark-3.3 profile
  2. Add Spark-3.3 module in spark-wrapper and add Code in spark-3.3
  3. Fix the code in spark-core to be compatible with spark3.0 3.1 3.2 3.3
    • Change the pattern matching in SetCatalogAndNamespace because the parament become ResolvedNamespace and ResolvedDBObjectName.
    • Add method dropNamespace(strings: Array[String]) in TiCatalog for spark3.3 change the parament of dropNamespace in SupportsNamespaces
    • Add method parseQuery in TiParser for spark3.3 add parserQuery in ParserInterface.
  4. Update log4j-api and log4j-core version to 2.17.2 and exclude it in other dependencies. or you will get java.lang.NoSuchMethodError: org.apache.logging.log4j.core.appender.ConsoleAppender$Builder.setImmediateFlush in spark3.3
  5. Exclude slf4j-log4j12 dependency hadoop-client or you will find multiple bindings of Log4jLoggerFactory on the classpath
  6. Update assembly to package spark-3.3 in spark wrapper
  7. Fix some tests

Check List

Tests

  1. IT
  • /run-all-tests profile=spark-3.3.0
  • /run-all-tests profile=spark-3.2.2
  • /run-all-tests profile=spark-3.1.3
  • /run-all-tests (spark 3.0.3)
  • /run-all-tests profile=spark 3.3.0 tidb = v5.3.0 tikv = v5.3.0 pd = v5.3.0
  1. Use Test
  • Package TiSpark with 3.0.3 and work with spark 3.0.3
  • Package TiSpark with 3.1.3 and work with spark 3.1.3
  • Package TiSpark with 3.2.2 and work with spark 3.2.2
  • Package TiSpark with 3.3.0 and work with spark 3.3.0

qidi1 avatar Aug 04 '22 15:08 qidi1

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shiyuhang0
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 04 '22 15:08 ti-chi-bot

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 04 '22 15:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 05 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 05 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 05 '22 03:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 05 '22 03:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 05 '22 07:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 03:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 07 '22 03:08 qidi1

/run-all-tests profile=spark-3.1.1

qidi1 avatar Aug 07 '22 06:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 07 '22 07:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 08:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 09:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 12:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 14:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 07 '22 14:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 08 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 08 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 02:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 05:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 09 '22 05:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 05:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 05:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 09 '22 06:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 06:08 qidi1

/run-all-tests profile=spark-3.3.0

qidi1 avatar Aug 09 '22 07:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 09 '22 08:08 qidi1

/run-all-tests profile=spark-3.1.1

qidi1 avatar Aug 09 '22 12:08 qidi1

/run-all-tests profile=spark-3.2.1

qidi1 avatar Aug 09 '22 13:08 qidi1