pingcap
changefeed (ticdc): extract a method and add some comments
What problem does this PR solve?
Issue Number: close #7291
What is changed and how it works?
Check List
Tests
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- hicqu
- sdojjy
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #7290 (9a98421) into master (8f81dbb) will decrease coverage by
0.0199%. The diff coverage is44.3243%.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| cdc | 67.2842% <43.5897%> (-0.0299%) |
:arrow_down: |
| dm | 51.9428% <26.9230%> (-0.0113%) |
:arrow_down: |
| engine | 61.0419% <57.1428%> (-0.0310%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #7290 +/- ##
================================================
- Coverage 59.7265% 59.7066% -0.0200%
================================================
Files 790 789 -1
Lines 91204 91211 +7
================================================
- Hits 54473 54459 -14
+ Misses 31987 31974 -13
- Partials 4744 4778 +34
This pull request has been accepted and is ready to merge.
@asddongmen: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.