tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

frontier(ticdc): fast check if region is split or merged when forwarding resolvedTs

Open sdojjy opened this issue 2 years ago • 9 comments

What problem does this PR solve?

Issue Number: close #7281

What is changed and how it works?

using map cached all region spans, when forwarding a span, check if it is split or merged by comparing the span start, span end, and region ID.

server CPU and memory: image

profile before: image

profile after image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

sdojjy avatar Sep 30 '22 09:09 sdojjy

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 30 '22 09:09 ti-chi-bot

/run-all-tests

sdojjy avatar Sep 30 '22 09:09 sdojjy

/run-all-tests

sdojjy avatar Oct 06 '22 14:10 sdojjy

/run-all-tests

sdojjy avatar Oct 06 '22 15:10 sdojjy

/run-all-tests

sdojjy avatar Oct 06 '22 16:10 sdojjy

/run-all-tests

sdojjy avatar Oct 06 '22 16:10 sdojjy

/run-integration-tests /run-verify-test

sdojjy avatar Oct 06 '22 16:10 sdojjy

/run-all-tests

sdojjy avatar Oct 06 '22 16:10 sdojjy

/run-all-tests

sdojjy avatar Oct 08 '22 02:10 sdojjy

/merge

asddongmen avatar Oct 09 '22 08:10 asddongmen

This pull request has been accepted and is ready to merge.

Commit hash: 43b9b4f30d7e51245466f9978a6e89fd6c4e499c

ti-chi-bot avatar Oct 09 '22 08:10 ti-chi-bot

/merge

sdojjy avatar Oct 09 '22 09:10 sdojjy

/run-verify-ci

3AceShowHand avatar Oct 09 '22 09:10 3AceShowHand

In response to a cherrypick label: new pull request created: #7303.

ti-chi-bot avatar Oct 10 '22 03:10 ti-chi-bot