pingcap
redo (ticdc): only delete changefeed related file when changefeed was removed
What problem does this PR solve?
Issue Number: close #6413
What is changed and how it works?
Check List
Tests
- Unit test
- Manual test (add detailed scripts or steps below)
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Fix a bug that may cause changefeed's redo log files be deleted wrongly.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- nongfushanquan
- zhaoxinyu
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #7279 (aeac209) into master (8f81dbb) will increase coverage by
0.0024%. The diff coverage is59.3442%.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| cdc | 67.2806% <62.6609%> (-0.0335%) |
:arrow_down: |
| dm | 51.9866% <36.6666%> (+0.0325%) |
:arrow_up: |
| engine | 61.0419% <57.1428%> (-0.0310%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #7279 +/- ##
================================================
+ Coverage 59.7265% 59.7289% +0.0023%
================================================
Files 790 789 -1
Lines 91204 91274 +70
================================================
+ Hits 54473 54517 +44
+ Misses 31987 31976 -11
- Partials 4744 4781 +37
This pull request has been accepted and is ready to merge.
@asddongmen: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.