tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sqlmodel(dm): support generating UPDATE CASE WHEN

Open lance6716 opened this issue 3 years ago • 6 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/3408

What is changed and how it works?

as title

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

lance6716 avatar Sep 29 '22 11:09 lance6716

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • buchuitoudegou

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 29 '22 11:09 ti-chi-bot

/run-dm-integration-test

lance6716 avatar Sep 29 '22 11:09 lance6716

/cc @GMHDBJD @dsdashun

lance6716 avatar Sep 29 '22 11:09 lance6716

/check-issue-triage-complete

lance6716 avatar Sep 29 '22 11:09 lance6716

/cc @Ehco1996

lance6716 avatar Sep 30 '22 01:09 lance6716

ptal @buchuitoudegou

lance6716 avatar Oct 08 '22 07:10 lance6716

ptal @GMHDBJD @dsdashun

lance6716 avatar Oct 10 '22 02:10 lance6716

ptal @GMHDBJD @dsdashun

lance6716 avatar Oct 11 '22 02:10 lance6716

Have not measured the syntax, not sure if the performance has improved and there are no other side effects

GMHDBJD avatar Oct 11 '22 06:10 GMHDBJD

/merge

lance6716 avatar Oct 11 '22 07:10 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: fefb0130b962ba05625988f9d804aee928c05863

ti-chi-bot avatar Oct 11 '22 07:10 ti-chi-bot

/run-verify

asddongmen avatar Oct 11 '22 08:10 asddongmen

Codecov Report

Merging #7268 (2e11a44) into master (2843d67) will increase coverage by 0.2463%. The diff coverage is 59.8176%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.7458% <65.2725%> (+0.5261%) :arrow_up:
dm 52.0036% <45.6521%> (+0.0985%) :arrow_up:
engine 60.8386% <53.6379%> (-0.2189%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7268        +/-   ##
================================================
+ Coverage   59.6477%   59.8940%   +0.2462%     
================================================
  Files           790        798         +8     
  Lines         91016      91550       +534     
================================================
+ Hits          54289      54833       +544     
+ Misses        31982      31946        -36     
- Partials       4745       4771        +26     

codecov-commenter avatar Oct 11 '22 08:10 codecov-commenter