externalresources(engine): support s3 as storage (Part 2)

[CharlesCheung96]

What problem does this PR solve?

Issue Number: ref #7114

What is changed and how it works?

• broker

  1. Create localFileManager and s3FileManager in NewBroker
  2. If S3 is configured, a dummy resource will be persisted by broker to indicate that its temporary files have not been cleaned, which is useful to prevent resource leaks.
  3. Asynchronously remove temporary files created by the worker in OnWorkerClosed
  4. If an Executor exits normally, the corresponding broker will attempt to clean up all temporary files before exiting. If this step fails, the dummy record is stored in Meta, which will be cleaned up by the GCCoordinator.

• manager

  1. DefaultGCCoordinator: SetGCPending when job offline. GCExecutors when executor offline.
  2. DefaultGCRunner: implement GCExecutors

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• amyangfei
• gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

[CharlesCheung96]

/run-engine-integration-test

[CharlesCheung96]

Broker integration tests verified in https://ci2.pingcap.net/blue/organizations/jenkins/engine_ghpr_integration_test/detail/engine_ghpr_integration_test/902/pipeline/86

[CharlesCheung96]

/run-all-tests

[codecov-commenter]

Codecov Report

Merging #7204 (fb13441) into master (8f81dbb) will decrease coverage by 0.0543%. The diff coverage is 56.7204%.

Additional details and impacted files

Flag	Coverage Δ
cdc	67.2571% <73.4375%> (-0.0570%)	:arrow_down:
dm	51.9413% <36.6666%> (-0.0127%)	:arrow_down:
engine	60.8392% <54.0955%> (-0.2337%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7204        +/-   ##
================================================
- Coverage   59.7265%   59.6721%   -0.0544%     
================================================
  Files           790        796         +6     
  Lines         91204      91639       +435     
================================================
+ Hits          54473      54683       +210     
- Misses        31987      32144       +157     
- Partials       4744       4812        +68     

[CharlesCheung96]

/run-all-tests

[CharlesCheung96]

/run-all-tests

[CharlesCheung96]

/run-all-tests

[amyangfei]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: fb134410927076564b57ce89561a1d84213e8104

[ti-chi-bot]

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.