tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

Some interface names in pkg/framework are not properly

Open lonng opened this issue 2 years ago • 0 comments

Before asking a question, make sure you have

  • [X] Searched existing Stack Overflow questions
  • [X] Googled your question
  • [X] Searched open and closed GitHub issues
  • [X] Read the documentation

What is your question?

There are some misleading interface names in the package tiflow/pkg/framework, like:

  • MasterImpl
  • WorkerImpl

In general, the *Impl suffix is used for some implementation classes in most programming languages. In my opinion, our MasterImpl/WorkerImpl will cause misunderstanding for newcome contributors.

lonng avatar Sep 22 '22 03:09 lonng