tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

syncer(dm): fix collation compatibility behaviour (#6833)

Open ti-chi-bot opened this issue 3 years ago • 2 comments

This is an automated cherry-pick of #6833

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #6832

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix when use "strict" collation_compatible, DM sometimes generate SQL with duplicated collation

ti-chi-bot avatar Aug 22 '22 10:08 ti-chi-bot

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 22 '22 10:08 ti-chi-bot

/hold related PR is not cherry-pick to TiDB release-6.1

lance6716 avatar Sep 22 '22 03:09 lance6716

/unhold /merge

lance6716 avatar Oct 12 '22 07:10 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: e35593c0ba7e48aae328f51c1cfda50170045345

ti-chi-bot avatar Oct 12 '22 07:10 ti-chi-bot

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Oct 12 '22 08:10 ti-chi-bot

/hold

lance6716 avatar Oct 12 '22 08:10 lance6716

/unhold /merge

lance6716 avatar Oct 12 '22 09:10 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: fc892e1c551cfb69b5e85f9b5c1dcada42f84948

ti-chi-bot avatar Oct 12 '22 09:10 ti-chi-bot

/run-all-tests

lance6716 avatar Oct 12 '22 09:10 lance6716

/run-kafka-integration-test /run-dm-integration-test

lance6716 avatar Oct 12 '22 09:10 lance6716

/hold

lance6716 avatar Oct 12 '22 09:10 lance6716

/unhold /merge

lance6716 avatar Oct 12 '22 09:10 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: 8d6186c42b57f8d6a203f3fe716d2fd196034cb1

ti-chi-bot avatar Oct 12 '22 09:10 ti-chi-bot

/run-all-tests

lance6716 avatar Oct 12 '22 09:10 lance6716

/run-kafka-integration-test

lance6716 avatar Oct 12 '22 10:10 lance6716

/run-kafka-integration-test

lance6716 avatar Oct 25 '22 10:10 lance6716