tiflow
tiflow copied to clipboard
[DNM] changefeed(ticdc): refactor new changefeed method attach the reactor directly
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.
If you don't think this PR needs a release note then fill it with `None`.
[REVIEW NOTIFICATION]
This pull request has been approved by:
- asddongmen
- zhaoxinyu
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
/run-all-tests
/run-all-tests
Codecov Report
Merging #6740 (2a25636) into master (2ea67ba) will increase coverage by
0.1615%
. The diff coverage is67.7444%
.
Flag | Coverage Δ | |
---|---|---|
cdc | 66.0350% <62.3390%> (+0.1669%) |
:arrow_up: |
dm | 52.1065% <72.9729%> (+0.0648%) |
:arrow_up: |
engine | 62.8005% <85.4961%> (+0.2644%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #6740 +/- ##
================================================
+ Coverage 59.2138% 59.3754% +0.1615%
================================================
Files 780 783 +3
Lines 88405 89116 +711
================================================
+ Hits 52348 52913 +565
- Misses 31415 31532 +117
- Partials 4642 4671 +29
/merge
This pull request has been accepted and is ready to merge.
/run-verify-ci
/run-leak-test /run-integration-test
/run-dm-compatibility-test