tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

validator(dm): fix unstable test

Open buchuitoudegou opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number: close #6734

What is changed and how it works?

  1. wait for min-flush-interval to ensure the second flush happens
  2. ensure the checkpoint is successfully flushed

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

buchuitoudegou avatar Aug 13 '22 15:08 buchuitoudegou

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 13 '22 15:08 ti-chi-bot

/area dm /run-dm-integration-test

buchuitoudegou avatar Aug 13 '22 15:08 buchuitoudegou

/run-dm-integration-test

buchuitoudegou avatar Aug 15 '22 02:08 buchuitoudegou

/check-issue-triage-complete

lance6716 avatar Aug 15 '22 02:08 lance6716

PTAL @D3Hunter @lichunzhu

lance6716 avatar Aug 15 '22 08:08 lance6716

/merge

lance6716 avatar Aug 15 '22 08:08 lance6716

This pull request has been accepted and is ready to merge.

Commit hash: 825947139f17846a2931c28e2ea85e42d669e2c5

ti-chi-bot avatar Aug 15 '22 08:08 ti-chi-bot

@buchuitoudegou: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Aug 15 '22 08:08 ti-chi-bot

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/8917/pipeline

possible unstable test: handle_error

/run-dm-integration-test

buchuitoudegou avatar Aug 15 '22 09:08 buchuitoudegou

In response to a cherrypick label: new pull request created: #6751.

ti-chi-bot avatar Aug 15 '22 09:08 ti-chi-bot