tiflow
tiflow copied to clipboard
pingcap
redo(ticdc): owner and processores shouldn't share one redo log writer (#6671)
This is an automated cherry-pick of #6671
Signed-off-by: qupeng [email protected]
What problem does this PR solve?
Issue Number: close #6695
What is changed and how it works?
Reusing log write in redo manager should be in a correct way
Check List
Tests
- Unit test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
This pull request has been accepted and is ready to merge.
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.
At the same time I will also trigger all tests for you:
/run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
release-6.1@5e2fdba). Click here to learn what that means. The diff coverage isn/a.
| Flag | Coverage Δ | |
|---|---|---|
| cdc | 62.0235% <0.0000%> (?) |
|
| dm | 52.0699% <0.0000%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## release-6.1 #6729 +/- ##
================================================
Coverage ? 56.4874%
================================================
Files ? 538
Lines ? 70529
Branches ? 0
================================================
Hits ? 39840
Misses ? 26898
Partials ? 3791
