tiflow
tiflow copied to clipboard
pingcap
api(cdc): drain capture also check store version (#6679)
This is an automated cherry-pick of #6679
What problem does this PR solve?
Issue Number: close #6677
What is changed and how it works?
when drain the capture, one capture drop all tables on it, and another capture add tables, which means the capture can contact tikv, which means tikv's version should be compatible with cdc.
Check List
Tests
- Unit test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick, it must first be approved by the collaborators.
AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
release-6.2@c0eaa00). Click here to learn what that means. The diff coverage isn/a.
| Flag | Coverage Δ | |
|---|---|---|
| cdc | 66.0803% <0.0000%> (?) |
|
| dm | 52.0510% <0.0000%> (?) |
|
| engine | 63.3992% <0.0000%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## release-6.2 #6693 +/- ##
================================================
Coverage ? 59.3649%
================================================
Files ? 757
Lines ? 87240
Branches ? 0
================================================
Hits ? 51790
Misses ? 30856
Partials ? 4594
This pull request is closed because it's related version has closed automatic cherry-picking. If it's still needed, you can reopen it or just regenerate it using bot, see:
- https://prow.tidb.io/command-help#cherrypick
- https://book.prow.tidb.net/#/plugins/cherrypicker
You can find more details at:
- https://internals.tidb.io/t/topic/785
