tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

tracker(dm): fix downstream table structure reports key too long (#6661)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #6661

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #5315

What is changed and how it works?

during the refactor of schema tracker, I found this issue is not hard to fix

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a problem that DM will report `Specified key was too long` error

ti-chi-bot avatar Aug 10 '22 03:08 ti-chi-bot

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 10 '22 03:08 ti-chi-bot

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot avatar Aug 10 '22 03:08 ti-chi-bot

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 9b5e363045b44a7fa44bf1f540d242490cced500 link true /test verify
pull-dm-integration-test 9b5e363045b44a7fa44bf1f540d242490cced500 link true /test dm-integration-test
pull-dm-compatibility-test 9b5e363045b44a7fa44bf1f540d242490cced500 link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 06 '23 05:07 ti-chi-bot[bot]

This pull request is closed because its related version has closed automatic cherry-picking. If it's still needed, you can reopen it or just regenerate it using bot, see:

https://prow.tidb.net/command-help#cherrypick https://book.prow.tidb.net/#/plugins/cherrypicker

ti-chi-bot avatar Dec 01 '23 08:12 ti-chi-bot