tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

servermaster(engine): implement openapi with grpc-gateway

Open sleepymole opened this issue 1 year ago • 1 comments

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/6668

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

sleepymole avatar Aug 09 '22 07:08 sleepymole

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 09 '22 07:08 ti-chi-bot

/run-leak-test

sleepymole avatar Aug 18 '22 08:08 sleepymole

/run-all-tests

amyangfei avatar Aug 18 '22 09:08 amyangfei

Codecov Report

Merging #6669 (df116f0) into master (435053b) will decrease coverage by 0.0022%. The diff coverage is 42.0895%.

Flag Coverage Δ
cdc 66.2224% <ø> (+0.1447%) :arrow_up:
dm 51.9961% <ø> (-0.0101%) :arrow_down:
engine 62.6835% <42.0895%> (-0.3430%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6669        +/-   ##
================================================
- Coverage   59.4341%   59.4318%   -0.0023%     
================================================
  Files           787        784         -3     
  Lines         89743      89489       -254     
================================================
- Hits          53338      53185       -153     
+ Misses        31702      31609        -93     
+ Partials       4703       4695         -8     

codecov-commenter avatar Aug 19 '22 03:08 codecov-commenter

/hold

I will check whether the chaos can pass later.

sleepymole avatar Aug 19 '22 03:08 sleepymole

Chaos test passed. https://github.com/gozssky/tiflow/actions/runs/2887117089

sleepymole avatar Aug 19 '22 05:08 sleepymole

/unhold /merge

sleepymole avatar Aug 19 '22 05:08 sleepymole

This pull request has been accepted and is ready to merge.

Commit hash: 0a6551188c710f7d5419b0972e3e9f196188eed0

ti-chi-bot avatar Aug 19 '22 05:08 ti-chi-bot

@gozssky: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Aug 19 '22 05:08 ti-chi-bot