tiflow
tiflow copied to clipboard
pingcap
cli/(ticdc): Validate `--overwrite-checkpoint-ts` boundary in changefeed resume (#6442)
This is an automated cherry-pick of #6442
What problem does this PR solve?
Issue Number: close #6350
What is changed and how it works?
- Prevent users from specifying '--overwrite-checkpoint-ts' with 0
- Fix an off-by-one problem that causes changefeed can be created/resumed but it will fail immediately.
Check List
Tests
- Unit test
- Integration test
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick, it must first be approved by the collaborators.
AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This pull request is closed because it's related version has closed automatic cherry-picking. If it's still needed, you can reopen it or just regenerate it using bot, see:
- https://prow.tidb.io/command-help#cherrypick
- https://book.prow.tidb.net/#/plugins/cherrypicker
You can find more details at:
- https://internals.tidb.io/t/topic/785
