tiflow
tiflow copied to clipboard
pingcap
sinkv2(ticdc): add txn sink mysql backend
What problem does this PR solve?
Issue Number: ref #5928
What is changed and how it works?
Add implementation for mysql sink.
Check List
Tests
- Unit test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[REVIEW NOTIFICATION]
This pull request has been approved by:
- hi-rustin
- nongfushanquan
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
Codecov Report
Merging #6510 (209c176) into master (f0e21a6) will increase coverage by
0.1098%. The diff coverage is75.0619%.
| Flag | Coverage Δ | |
|---|---|---|
| cdc | 66.2926% <76.6355%> (+0.2156%) |
:arrow_up: |
| dm | 52.0766% <22.2222%> (+0.0038%) |
:arrow_up: |
| engine | 63.7955% <70.7113%> (-0.3054%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #6510 +/- ##
================================================
+ Coverage 59.4618% 59.5716% +0.1098%
================================================
Files 762 766 +4
Lines 87377 88067 +690
================================================
+ Hits 51956 52463 +507
- Misses 30815 30968 +153
- Partials 4606 4636 +30
This PR is so big
@lonng It has been split into 3 PRs now. Line of code reduces from 4K to 2.5K now. I guess it can be reviewed now as most code is just migrated.
This pull request has been accepted and is ready to merge.