tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

redo log: storage permission pre-check is need

Open Tammyxia opened this issue 3 years ago • 2 comments

What did you do?

  • When create changefeed with redo log storage config like this: [consistent] level = "eventual" max-log-size = 1 storage = "nfs:///mnt/nfs/var/nfs"

  • But some cdc server have not this directory "/mnt/nfs/var/nfs", the behavior right now is : create changefeed can be successful, but later storage persimission deny: "[CDC:ErrRedoFileOp]redo file operation: open /mnt/nfs/var/nfs/172.16.6.46:8420_mysql-test1_meta.meta.mtmp: permission denied"

  • It's better if storage directory/permission is pre-checked before successfully creating changefeed.

What did you expect to see?

No response

What did you see instead?

As above

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
v6.2.0 nightly

Tammyxia avatar Jul 18 '22 13:07 Tammyxia

storage config also has not pre-check, for example, { "id": "redo-apply-cdc-all-node-restart-sync", "namespace": "default", "summary": { "state": "error", "tso": 434713341392060417, "checkpoint": "2022-07-20 06:49:54.739", "error": { "addr": "upstream-ticdc-0.upstream-ticdc-peer.cdc-testbedcl8xv.svc:8301", "code": "CDC:ErrOwnerUnknown", "message": "parse "s3://nfs/test-infra-redolog/redo-apply-cdc-all-node-restart-sync-%!s(func(int64, int64) time.Time=0x1023964a0)-2022-07-20 14:49:51.202209 %2B0800 CST m=%2B0.069564334?access-key=minioadmin\u0026secret-access-key=minioadmin\u0026endpoint=http://minio.pingcap.net:9000\u0026force-path-style=true": invalid URL escape "%!s"" }

Tammyxia avatar Jul 20 '22 06:07 Tammyxia

/assign @asddongmen

nongfushanquan avatar Sep 22 '22 02:09 nongfushanquan

/label affects-6.1

nongfushanquan avatar Jan 04 '23 06:01 nongfushanquan

/label affects-6.5

nongfushanquan avatar Jan 04 '23 07:01 nongfushanquan