tiflow
tiflow copied to clipboard
pingcap
loader(dm): Improve the way of creating subdirectory
What problem does this PR solve?
Issue Number: close #6018
What is changed and how it works?
change the way of loader dir to use subdirectory. and consider the compatibility of upgrade and downgrade.
before v6.1 loader path is like:
s3 --> user_set_dir + / + taskName + . + sourceID
local --> user_set_dir + . + taskName
after v6.1 loader path is like:
s3 --> user_set_dir + / + taskName + . + sourceID
local --> user_set_dir + . + sourceID + . + taskName
For upgrade:
s3 --> do nothing
local --> dm should automatically move files, users do nothing
For downgrade:
s3 --> do nothing
local --> do nothing, because new path's suffix is still '.taskName'
Check List
Tests
- Unit test
- Integration test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[REVIEW NOTIFICATION]
This pull request has not been approved.
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
just submit some ideas code, and i will improve the code and supplement the test later.
@WizardXiao: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.