pingcap
deps: upgrade aws-sdk-go-v2 dependency (#12425)
This is an automated cherry-pick of #12425
What problem does this PR solve?
Issue Number: close #12424
What is changed and how it works?
According to the comment https://github.com/aws/aws-sdk-go-v2/issues/2370#issuecomment-1953308268, we upgrade the dependency and add a test for this error.
Check List
Tests
- Unit test
- Integration test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Upgrade aws-sdk-go-v2 dependency to fix glue schema registry
@wk989898 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's AWS SDK for Go v2 dependencies to resolve a critical issue affecting the Glue Schema Registry. The upgrade aims to enhance stability and correct a specific problem where the Glue Schema Registry encountered endpoint resolution failures, ensuring smoother operation for related functionalities.
Highlights
- Dependency Upgrade: Upgraded the
aws-sdk-go-v2dependency and its associated sub-modules to their latest versions. - Glue Schema Registry Fix: Resolved an issue with the Glue Schema Registry, specifically addressing problems related to endpoint resolution, by updating the AWS SDK dependencies.
- New Integration Test: Added a new integration test case to verify the correct handling of Glue Schema Registry configuration errors, ensuring that previous endpoint resolution failures are no longer encountered.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wk989898
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [wk989898]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please upload report for BASE (release-8.5@951f487). Learn more about missing BASE report.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 57.7927% <0.0000%> (?) |
|
| dm | 48.6888% <0.0000%> (?) |
|
| engine | 50.7442% <0.0000%> (?) |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 53.4213% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## release-8.5 #12453 +/- ##
================================================
Coverage ? 53.4213%
================================================
Files ? 1004
Lines ? 137007
Branches ? 0
================================================
Hits ? 73191
Misses ? 58360
Partials ? 5456
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
