tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

DM: Fix docs link

Open dveeden opened this issue 1 month ago • 9 comments

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

The link should be pointing to https://docs.pingcap.com/tidb/stable/mysql-compatibility#ddl-operations

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

dveeden avatar Nov 28 '25 14:11 dveeden

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation issue by updating an incorrect link embedded within DDL parsing error messages in the DM component. The change ensures that users encountering these specific errors are directed to the most current and relevant section of the TiDB documentation regarding DDL operations, improving the clarity and helpfulness of error messages.

Highlights

  • Documentation Link Update: The pull request updates an outdated documentation link within error messages related to DDL parsing. The old link https://docs.pingcap.com/tidb/stable/mysql-compatibility#ddl has been corrected to https://docs.pingcap.com/tidb/stable/mysql-compatibility#ddl-operations.
  • Consistency Across Error Definitions: This link correction has been applied consistently across multiple files that define error messages, including errors_release.txt, errors.toml, and error_list.go, ensuring all references point to the accurate documentation section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 28 '25 14:11 gemini-code-assist[bot]

/label skip-issue-check /cc @lance @GMHDBJD

dveeden avatar Nov 28 '25 14:11 dveeden

@dveeden: The label(s) skip-issue-check cannot be applied. These labels are supported: MariaDB, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.5, affects-9.0, bug-from-internal-test, bug-from-user, duplicate, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, may-affects-8.5, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, needs-cherry-pick-release-9.0-beta.2, nextgen, question, release-blocker, wontfix.

In response to this:

/label skip-issue-check /cc @lance @GMHDBJD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot[bot] avatar Nov 28 '25 14:11 ti-chi-bot[bot]

@dveeden: GitHub didn't allow me to request PR reviews from the following users: lance.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/label skip-issue-check /cc @lance @GMHDBJD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Nov 28 '25 14:11 ti-chi-bot[bot]

/cc @lance6716

dveeden avatar Nov 28 '25 15:11 dveeden

/retest

dveeden avatar Nov 28 '25 15:11 dveeden

/cc @OliverS929

dveeden avatar Dec 16 '25 10:12 dveeden

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 16 '25 11:12 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2025-11-28 15:19:54.41414371 +0000 UTC m=+17539.227921283: :ballot_box_with_check: agreed by lance6716.
  • 2025-12-16 11:42:38.747434259 +0000 UTC m=+1559703.561211832: :ballot_box_with_check: agreed by GMHDBJD.

ti-chi-bot[bot] avatar Dec 16 '25 11:12 ti-chi-bot[bot]

/retest

lance6716 avatar Dec 22 '25 13:12 lance6716

/retest

dveeden avatar Dec 22 '25 14:12 dveeden