server(ticdc): make options struct fields public for ticdc new architecture (#12105)

[ti-chi-bot]

This is an automated cherry-pick of #12105

What problem does this PR solve?

Issue Number: close #12104

What is changed and how it works?

This PR capitalizes all fields in the Options struct to make them publicly accessible. Previously, the struct itself was made public, but its fields remained private, limiting its usability in the new TiCDC architecture.

Check List

Tests

• Unit test
• Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

[ti-chi-bot]

@wlwilliamx This PR has conflicts, I have hold it. Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

[ti-chi-bot[bot]]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot[bot]]

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[gemini-code-assist[bot]]

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the options struct within the TiCDC server command to expose its fields publicly. This modification is essential for the new TiCDC architecture, which requires direct access to these configuration parameters. The change involves renaming the struct and its fields to follow Go's public visibility conventions, along with updating all corresponding usage sites.

Highlights

• Public Accessibility: The options struct in pkg/cmd/server/server.go has been renamed to Options and all its fields have been capitalized, making them publicly accessible. This change is specifically noted as being for the new TiCDC architecture.
• Code Refactoring: All references to the options struct and its fields throughout pkg/cmd/server/server.go and pkg/cmd/server/server_test.go have been updated to reflect the new capitalized names, ensuring consistency and correct access.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[ti-chi-bot[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlwilliamx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [wlwilliamx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[wlwilliamx]

/hold

[ti-chi-bot[bot]]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-verify	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-verify
pull-dm-integration-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-dm-integration-test
pull-cdc-integration-pulsar-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-cdc-integration-pulsar-test
pull-cdc-integration-kafka-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-cdc-integration-kafka-test
pull-cdc-integration-mysql-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-cdc-integration-mysql-test
pull-cdc-integration-storage-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-cdc-integration-storage-test
pull-dm-compatibility-test	2c84ccd48095694fcab25fac00477d31b499e3e0	link	true	/test pull-dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.