server(ticdc): export ticdc server options struct for public use in new architecture (#12102)
This is an automated cherry-pick of #12102
What problem does this PR solve?
Issue Number: close #12101
What is changed and how it works?
This PR refactors and exports the TiCDC server options struct to be publicly accessible, which is needed in #12098.
Check List
Tests
- Unit test
- Integration test
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
None
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick:
- It must be approved by the approvers firstly.
- AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@wlwilliamx This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the TiCDC server's configuration handling by exporting its options structure and providing a public Run function. This change enables external components, particularly those in a new architectural design, to programmatically interact with and launch the TiCDC server with its defined options, facilitating greater modularity and integration.
Highlights
- Export
optionsstruct: Theoptionsstruct for the TiCDC server has been renamed toOptionsand made public. This change is necessary to support a new architecture, specifically for use in #12098. - Introduce
Runfunction: A newRunfunction has been introduced, which encapsulates thecomplete,validate, andrunmethods of theOptionsstruct. This function is also exported for public use in the new TiCDC architecture.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: wlwilliamx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [wlwilliamx]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-verify | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-verify |
| pull-dm-integration-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-dm-integration-test |
| pull-cdc-integration-kafka-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-cdc-integration-kafka-test |
| pull-cdc-integration-pulsar-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-cdc-integration-pulsar-test |
| pull-cdc-integration-storage-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-cdc-integration-storage-test |
| pull-cdc-integration-mysql-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-cdc-integration-mysql-test |
| pull-dm-compatibility-test | eb5fd77c9394bd2e75022937b3786bbde9a6b555 | link | true | /test pull-dm-compatibility-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.