pingcap
ci(*): deprecate github action jobs to prevent developer misunderstanding and interference
What problem does this PR solve?
Issue Number: close #12361
What is changed and how it works?
This PR completely removes the "Check & Build" GitHub Actions workflow by deleting the .github/workflows/check_and_build.yaml file.
Why is this change necessary?
The "Check & Build" workflow is a known source of instability and random failures. These failures often have no connection to the code changes being proposed in a pull request.
Crucially, these jobs are not required checks for merging a PR. However, their failure frequently confuses contributors, leading them to believe their PR is blocked. This creates unnecessary noise and requires developers to investigate non-critical issues.
By removing this workflow, we aim to:
- Eliminate a flaky and unstable CI process.
- Reduce confusion for developers during the PR process.
- Save CI resources that were being used on these non-essential builds.
What has been changed?
The file .github/workflows/check_and_build.yaml has been deleted. This action removes the following CI jobs that were previously triggered on pull requests and pushes to master and release branches:
-
docker_build: This job ran onubuntu-latestand executed the following steps:docker build -f ./deployments/ticdc/docker/Dockerfile .docker build -f ./dm/Dockerfile .docker build -f ./deployments/engine/docker/Dockerfile .
-
mac_build: This job ran onmacos-latestand was responsible for:- Setting up the Go
v1.23environment. - Running
make build. - Running
make check.
- Setting up the Go
-
arm_build: This job ran on a self-hostedARM64runner and was responsible for:- Setting up the Go
v1.23environment. - Running
make build.
- Setting up the Go
The removal of the file also gets rid of the workflow's trigger conditions and concurrency settings.
Check List
Tests
- No code
Questions
Will it cause performance regression or break compatibility?
None
Do you need to update user documentation, design documentation or monitoring documentation?
None
Release note
None
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.
To merge this cherry pick:
- It must be approved by the approvers firstly.
- AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[!NOTE] Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
@OliverS929: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
LGTM
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Benjamin2037, lidezhu, OliverS929, wk989898
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lidezhu,wk989898]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment