tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

schemaStorage(ticdc): remove `schemaVersion` in `schemaStorage` (#11869)

Open ti-chi-bot opened this issue 1 year ago • 5 comments

This is an automated cherry-pick of #11869

What problem does this PR solve?

Issue Number: close #11868

What is changed and how it works?

This PR removes the SchemaVersion field and its associated logic from the schemaStorage component in TiCDC. The change is part of an effort to remove schema change checking and reduce redundant logic.

Related to #11733.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

ti-chi-bot avatar Dec 20 '24 14:12 ti-chi-bot

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@4e1296c). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.4847% <0.0000%> (?)
dm 51.0367% <0.0000%> (?)
engine 63.4091% <0.0000%> (?)
Flag Coverage Δ
unit 57.2704% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11919   +/-   ##
================================================
  Coverage               ?   57.2704%           
================================================
  Files                  ?        854           
  Lines                  ?     126554           
  Branches               ?          0           
================================================
  Hits                   ?      72478           
  Misses                 ?      48637           
  Partials               ?       5439           
:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 24 '24 10:12 codecov[bot]

/test cdc-integration-kafka-test

wlwilliamx avatar Dec 26 '24 07:12 wlwilliamx

@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot[bot] avatar Dec 27 '24 07:12 ti-chi-bot[bot]

/approve

wlwilliamx avatar Dec 27 '24 07:12 wlwilliamx

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wlwilliamx Once this PR has been reviewed and has the lgtm label, please assign suzaku for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Dec 27 '24 07:12 ti-chi-bot[bot]