tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

kvclient, schemaStorage(ticdc): simplify the logs and refactor schema storage initialization

Open 3AceShowHand opened this issue 1 year ago • 6 comments

What problem does this PR solve?

Issue Number: close #11788

What is changed and how it works?

  • add more field to the log when the ddl is received at the very first time
  • remove verbose duplicate log, just print the job id should be fine in the later logs

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

3AceShowHand avatar Nov 22 '24 09:11 3AceShowHand

/retest

3AceShowHand avatar Nov 26 '24 09:11 3AceShowHand

/retest

3AceShowHand avatar Nov 26 '24 09:11 3AceShowHand

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [asddongmen,wk989898]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 26 '24 10:11 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 02:30:49.99838247 +0000 UTC m=+430837.618036971: :ballot_box_with_check: agreed by wk989898.
  • 2024-11-26 10:44:04.929732545 +0000 UTC m=+546832.549387046: :ballot_box_with_check: agreed by asddongmen.

ti-chi-bot[bot] avatar Nov 26 '24 10:11 ti-chi-bot[bot]

/retest

3AceShowHand avatar Mar 07 '25 08:03 3AceShowHand

@3AceShowHand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 7294efe32fdc428bcb1bb3f0548f4da55df84106 link true /test verify
pull-verify e5646b68a8158e740da67cc13aafe86a33a9fe19 link true /test pull-verify
pull-cdc-integration-mysql-test e5646b68a8158e740da67cc13aafe86a33a9fe19 link true /test pull-cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Mar 12 '25 07:03 ti-chi-bot[bot]