tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

gomod(dm): upgrade go-mysql to 1.9.1 (#11630)

Open ti-chi-bot opened this issue 1 year ago • 5 comments

This is an automated cherry-pick of #11630

What problem does this PR solve?

Issue Number: close #11603

What is changed and how it works?

update github.com/go-mysql-org/go-mysql version from 1.7.1 to 1.9.1, which support connecting to mysql 8.0 with password longer than 19 characters.

Check List

Tests

  • Unit test
  • Manual test

Manual test: run quick-start dm task and saw no more connection error.

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

ti-chi-bot avatar Nov 05 '24 08:11 ti-chi-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ehco1996 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 05 '24 08:11 ti-chi-bot[bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Nov 05 '24 08:11 ti-chi-bot[bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify bea67552e90863c8b0f6258e4603755402017a9d link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Nov 05 '24 09:11 ti-chi-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-8.1@8832898). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.4390% <0.0000%> (?)
dm 51.1569% <0.0000%> (?)
engine 63.4444% <0.0000%> (?)
Flag Coverage Δ
unit 57.2976% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11719   +/-   ##
================================================
  Coverage               ?   57.2976%           
================================================
  Files                  ?        854           
  Lines                  ?     126623           
  Branches               ?          0           
================================================
  Hits                   ?      72552           
  Misses                 ?      48632           
  Partials               ?       5439           
:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 03 '25 03:01 codecov[bot]

/retest

kennytm avatar May 28 '25 05:05 kennytm