tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

cmd(ticdc): Export All cdc Subcommands

Open wlwilliamx opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: close #11676

What is changed and how it works?

Export all cdc subcommands for the new arch of ticdc to use.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

wlwilliamx avatar Oct 22 '24 08:10 wlwilliamx

/check-issue-triage-complete

asddongmen avatar Oct 22 '24 08:10 asddongmen

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [asddongmen,lidezhu]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Oct 22 '24 09:10 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 08:32:35.400887652 +0000 UTC m=+339956.097678259: :ballot_box_with_check: agreed by asddongmen.
  • 2024-10-22 09:32:59.336618686 +0000 UTC m=+343580.033409309: :ballot_box_with_check: agreed by lidezhu.

ti-chi-bot[bot] avatar Oct 22 '24 09:10 ti-chi-bot[bot]

/retest

wlwilliamx avatar Oct 22 '24 09:10 wlwilliamx

/retest

wlwilliamx avatar Oct 22 '24 10:10 wlwilliamx

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.1621%. Comparing base (60e2bfa) to head (295e21e). Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6419% <0.0000%> (-0.0018%) :arrow_down:
dm 50.0596% <ø> (+0.0192%) :arrow_up:
engine 53.2279% <ø> (-0.0396%) :arrow_down:
Flag Coverage Δ
unit 55.1621% <0.0000%> (+0.0013%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11677        +/-   ##
================================================
+ Coverage   55.1607%   55.1621%   +0.0013%     
================================================
  Files          1001       1001                
  Lines        136472     136474         +2     
================================================
+ Hits          75279      75282         +3     
+ Misses        55685      55681         -4     
- Partials       5508       5511         +3     

codecov[bot] avatar Oct 22 '24 10:10 codecov[bot]

/retest

wlwilliamx avatar Oct 22 '24 10:10 wlwilliamx

/retest

wlwilliamx avatar Oct 22 '24 13:10 wlwilliamx

/retest

wlwilliamx avatar Oct 22 '24 13:10 wlwilliamx

/retest

wlwilliamx avatar Oct 23 '24 02:10 wlwilliamx