tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sourcemanager(ticdc): close all pullers asyncrhonsly to prevent block too long

Open 3AceShowHand opened this issue 1 year ago • 2 comments

What problem does this PR solve?

Issue Number: ref #11638

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

3AceShowHand avatar Oct 21 '24 07:10 3AceShowHand

/retest

3AceShowHand avatar Oct 31 '24 08:10 3AceShowHand

/approve

3AceShowHand avatar Oct 31 '24 10:10 3AceShowHand

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [3AceShowHand,asddongmen,hicqu]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 04 '24 08:11 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-11-04 08:03:27.675632993 +0000 UTC m=+855320.514788539: :ballot_box_with_check: agreed by hicqu.
  • 2024-11-04 08:04:26.207354529 +0000 UTC m=+855379.046510075: :ballot_box_with_check: agreed by asddongmen.

ti-chi-bot[bot] avatar Nov 04 '24 08:11 ti-chi-bot[bot]