tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

model(ticdc): optimize OffsetsByNames function

Open wk989898 opened this issue 1 year ago • 5 comments

What problem does this PR solve?

Issue Number: close #11487

What is changed and how it works?

As title.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

wk989898 avatar Aug 15 '24 11:08 wk989898

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Aug 15 '24 11:08 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from wk989898, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Nov 11 '24 09:11 ti-chi-bot[bot]

/retest

wk989898 avatar Nov 12 '24 02:11 wk989898

/retest

wk989898 avatar Nov 12 '24 05:11 wk989898

Codecov Report

:x: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.1606%. Comparing base (64decf6) to head (3c62848). :warning: Report is 137 commits behind head on master.

:x: Your project check has failed because the head coverage (53.6074%) is below the target coverage (60.0000%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
Components Coverage Δ
cdc 54.9774% <66.6666%> (-4.6028%) :arrow_down:
dm 48.7562% <ø> (-1.3112%) :arrow_down:
engine ∅ <ø> (∅)
Flag Coverage Δ
unit 53.6074% <66.6666%> (-1.5285%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11488        +/-   ##
================================================
+ Coverage   55.1358%   55.1606%   +0.0248%     
================================================
  Files          1001       1001                
  Lines        136521     136523         +2     
================================================
+ Hits          75272      75307        +35     
+ Misses        55740      55707        -33     
  Partials       5509       5509                
:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 12 '24 07:11 codecov[bot]