tiflow
tiflow copied to clipboard
kafka(ticdc): fix kafka consumer doesn't check partition and old message
What problem does this PR solve?
Issue Number: close #11482
What is changed and how it works?
Add partition check and old message check about simple protocol
Check List
Tests
- Unit test
- Integration test
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
Hi @wk989898. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/retest
/check-issue-triage-complete
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 56.8732%. Comparing base (
1e3766e) to head (ecfcb00). Report is 54 commits behind head on master.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 62.0692% <ø> (+0.8667%) |
:arrow_up: |
| dm | 51.2395% <ø> (+0.1939%) |
:arrow_up: |
| engine | 53.4895% <ø> (-9.8843%) |
:arrow_down: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 56.8732% <ø> (-0.5880%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11483 +/- ##
================================================
- Coverage 57.4612% 56.8732% -0.5880%
================================================
Files 850 1001 +151
Lines 126407 140697 +14290
================================================
+ Hits 72635 80019 +7384
- Misses 48364 54986 +6622
- Partials 5408 5692 +284
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 3AceShowHand, asddongmen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [3AceShowHand,asddongmen]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
2024-09-02 10:46:50.207460661 +0000 UTC m=+268534.725513582: :ballot_box_with_check: agreed by 3AceShowHand.2024-10-31 02:59:58.373875274 +0000 UTC m=+491511.213030820: :ballot_box_with_check: agreed by asddongmen.
/retest