tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

mounter(ticdc): decode bytes-level checksum and encode columns-level checksum (#10706)

Open ti-chi-bot opened this issue 1 year ago • 4 comments

This is an automated cherry-pick of #10706

What problem does this PR solve?

Issue Number: close #10969

What is changed and how it works?

  • mounter decode checksum v2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

ti-chi-bot avatar Jul 03 '24 02:07 ti-chi-bot

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 03 '24 02:07 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jul 03 '24 02:07 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 60.28369% with 56 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.2@29aac52). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.3804% <0.0000%> (?)
dm 51.1849% <0.0000%> (?)
engine 63.3879% <0.0000%> (?)
Flag Coverage Δ
unit 57.5994% <60.2836%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.2     #11380   +/-   ##
================================================
  Coverage               ?   57.5994%           
================================================
  Files                  ?        849           
  Lines                  ?     126286           
  Branches               ?          0           
================================================
  Hits                   ?      72740           
  Misses                 ?      48136           
  Partials               ?       5410           

codecov[bot] avatar Jul 03 '24 02:07 codecov[bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test d6c60e76bb67a3fc7dcbd17ce1ad3c9ac19ded34 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Jul 03 '24 02:07 ti-chi-bot[bot]

no need to cherry-pick back to release-8.2

3AceShowHand avatar Jul 30 '24 07:07 3AceShowHand