pingcap
util(dm): update checking for fake rotate event
What problem does this PR solve?
Issue Number: close #11381
What is changed and how it works?
make fake rotate event checking more strict
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
Codecov Report
Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
Project coverage is 57.6196%. Comparing base (
707238a) to head (6c3c207).
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 61.3681% <ø> (-0.0353%) |
:arrow_down: |
| dm | 51.2483% <83.3333%> (+0.0250%) |
:arrow_up: |
| engine | 63.4091% <ø> (+0.0211%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 57.6196% <83.3333%> (-0.0055%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11360 +/- ##
================================================
- Coverage 57.6250% 57.6196% -0.0055%
================================================
Files 849 849
Lines 126261 126266 +5
================================================
- Hits 72758 72754 -4
- Misses 48098 48106 +8
- Partials 5405 5406 +1
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lyzx2001: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: D3Hunter, GMHDBJD, lyzx2001
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~dm/OWNERS~~ [D3Hunter,GMHDBJD]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment