tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

s3(ticdc): do not report unretryable error when initializing s3 storage (#11312)

Open ti-chi-bot opened this issue 1 year ago • 3 comments

This is an automated cherry-pick of #11312

What problem does this PR solve?

Issue Number: close #11311

What is changed and how it works?

do not report unretryable error when initializing s3 storage, because this kind of error is retryale, return ErrStorageInitialize if the external storage initialization fails.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

ti-chi-bot avatar Jun 15 '24 01:06 ti-chi-bot

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@20ee93f). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.9411% <0.0000%> (?)
dm 51.3194% <0.0000%> (?)
engine 63.4373% <0.0000%> (?)
Flag Coverage Δ
unit 57.5778% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11319   +/-   ##
================================================
  Coverage               ?   57.5778%           
================================================
  Files                  ?        853           
  Lines                  ?     126125           
  Branches               ?          0           
================================================
  Hits                   ?      72620           
  Misses                 ?      48091           
  Partials               ?       5414           

codecov[bot] avatar Jun 15 '24 01:06 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jun 17 '24 01:06 ti-chi-bot[bot]

/retest

3AceShowHand avatar Aug 01 '24 08:08 3AceShowHand

/retest

3AceShowHand avatar Aug 01 '24 09:08 3AceShowHand