tiflow
tiflow copied to clipboard
owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly (#11042)
This is an automated cherry-pick of #11042
What problem does this PR solve?
Issue Number: close #10998
What is changed and how it works?
When changefeed state has changed, reacquiring changefeed-error-stuck-duration
. feedStateManager
checks for new value about changefeedErrorStuckDuration
every feedStateManager.Tick
call so that it can sense the updated value.
Check List
Tests
- Unit test
- Manual test (add detailed scripts or steps below)
- start a CDC server
- run script
changefeed.tomlbin/cdc cli changefeed create -c test --sink-uri "kafka://127.0.0.1:9092/test?topic=test&protocol=open-protocol&max-message-bytes=41943040&compressionType=ZLIB" --changefeed-id="test" bin/cdc cli changefeed pause --changefeed-id="test" bin/cdc cli changefeed update --changefeed-id="test" --config=changefeed.toml bin/cdc cli changefeed resume --changefeed-id="test"
changefeed-error-stuck-duration = "1h30m"
- check CDC log
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None
/retest
Manual test pass
/retest
/retest
@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CharlesCheung96, wk989898
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment