tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly (#11042)

Open ti-chi-bot opened this issue 9 months ago • 3 comments

This is an automated cherry-pick of #11042

What problem does this PR solve?

Issue Number: close #10998

What is changed and how it works?

When changefeed state has changed, reacquiring changefeed-error-stuck-duration. feedStateManager checks for new value about changefeedErrorStuckDuration every feedStateManager.Tick call so that it can sense the updated value.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
    1. start a CDC server
    2. run script
    bin/cdc cli changefeed create -c test --sink-uri "kafka://127.0.0.1:9092/test?topic=test&protocol=open-protocol&max-message-bytes=41943040&compressionType=ZLIB" --changefeed-id="test"
    bin/cdc cli changefeed pause --changefeed-id="test"
    bin/cdc cli changefeed update --changefeed-id="test" --config=changefeed.toml
    bin/cdc cli changefeed resume --changefeed-id="test"
    
    changefeed.toml
     changefeed-error-stuck-duration = "1h30m"
    
    1. check CDC log Screenshot 2024-05-11 at 17 05 18

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

ti-chi-bot avatar May 13 '24 14:05 ti-chi-bot

/retest

wk989898 avatar May 14 '24 06:05 wk989898

Manual test pass

wk989898 avatar May 14 '24 06:05 wk989898

/retest

wk989898 avatar May 14 '24 08:05 wk989898

/retest

wk989898 avatar May 14 '24 11:05 wk989898

@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar May 15 '24 07:05 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 15 '24 07:05 ti-chi-bot[bot]