tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sink(ticdc): only enable batch dml for more than one row (#10971)

Open ti-chi-bot opened this issue 9 months ago • 3 comments

This is an automated cherry-pick of #10971

What problem does this PR solve?

Issue Number: close #10972

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below) run sysbench oltp_update_non_index and compare the performance.

image Sink throughput increase from 22k to 34k.

image Downstream tidb cpu usage decrease from 1600% to 1300%.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

ti-chi-bot avatar May 08 '24 07:05 ti-chi-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign hicqu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 08 '24 07:05 ti-chi-bot[bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar May 08 '24 07:05 ti-chi-bot[bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify ad4ec6d098663d79d5f891f9cab4f7db004a187d link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar May 08 '24 07:05 ti-chi-bot[bot]

/retest

lidezhu avatar May 20 '24 08:05 lidezhu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 20 '24 08:05 ti-chi-bot[bot]

/test all

lidezhu avatar May 20 '24 08:05 lidezhu

/test all

purelind avatar May 20 '24 09:05 purelind

/test verify

wuhuizuo avatar May 20 '24 10:05 wuhuizuo

/retest

purelind avatar May 20 '24 12:05 purelind

/retest

lidezhu avatar May 20 '24 15:05 lidezhu

/test verify

lidezhu avatar May 21 '24 01:05 lidezhu

/test dm-integration-test

lidezhu avatar May 21 '24 02:05 lidezhu

/test dm-integration-test

lidezhu avatar May 21 '24 03:05 lidezhu