tiflow
tiflow copied to clipboard
chore: fix some typo about Changefeed
What problem does this PR solve?
Issue Number: close #11049
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign maxshuang for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @wk989898. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
[LGTM Timeline notifier]
Timeline:
-
2024-05-21 04:03:42.674044924 +0000 UTC m=+2144376.431180498
: :ballot_box_with_check: agreed by asddongmen. -
2024-05-28 03:58:12.8025498 +0000 UTC m=+2748846.559685373
: :ballot_box_with_check: agreed by hongyunyan.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asddongmen, CharlesCheung96, hongyunyan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96,asddongmen,hongyunyan]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 57.3101%. Comparing base (
cf7055d
) to head (233eea5
).
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.4270% <50.0000%> (∅) |
|
dm | 51.1820% <ø> (-0.0283%) |
:arrow_down: |
engine | 63.4020% <ø> (-0.0071%) |
:arrow_down: |
Flag | Coverage Δ | |
---|---|---|
unit | 57.3101% <50.0000%> (+3.3912%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11050 +/- ##
================================================
+ Coverage 53.9188% 57.3101% +3.3912%
================================================
Files 403 857 +454
Lines 63781 127262 +63481
================================================
+ Hits 34390 72934 +38544
- Misses 26694 48929 +22235
- Partials 2697 5399 +2702
/retest
/retest