tiflow
tiflow copied to clipboard
owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly
What problem does this PR solve?
Issue Number: close #10998
What is changed and how it works?
When changefeed state has changed, reacquiring changefeed-error-stuck-duration
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign amyangfei for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Hi @wk989898. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test all
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.3879%. Comparing base (
894b36f
) to head (ce895c0
). Report is 10 commits behind head on master.
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.6153% <100.0000%> (-0.0494%) |
:arrow_down: |
dm | 51.2472% <ø> (+0.0095%) |
:arrow_up: |
engine | 63.4585% <ø> (+0.0706%) |
:arrow_up: |
Flag | Coverage Δ | |
---|---|---|
unit | 57.3879% <100.0000%> (-0.0088%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11042 +/- ##
================================================
- Coverage 57.3966% 57.3879% -0.0088%
================================================
Files 851 851
Lines 125469 125617 +148
================================================
+ Hits 72015 72089 +74
- Misses 48034 48115 +81
+ Partials 5420 5413 -7
/ok-to-test
Please also add an unit test case to cover this change.
/test all
@wk989898: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
jenkins-ticdc/verify | ce895c09900dbc7d92451a2ed13cf85bd88fc51e | link | true | /test verify |
pull-cdc-integration-kafka-test | ce895c09900dbc7d92451a2ed13cf85bd88fc51e | link | true | /test cdc-integration-kafka-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asddongmen, CharlesCheung96
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96,asddongmen]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-05-12 23:47:32.668209341 +0000 UTC m=+1437806.425344910
: :ballot_box_with_check: agreed by asddongmen. -
2024-05-13 08:52:38.678043967 +0000 UTC m=+1470512.435179540
: :ballot_box_with_check: agreed by CharlesCheung96.
/retest
In response to a cherrypick label: new pull request created to branch release-7.5
: #11083.
In response to a cherrypick label: new pull request created to branch release-8.1
: #11085.