tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sink (ticdc): fix sourceID error (#11021)

Open ti-chi-bot opened this issue 2 months ago • 2 comments

This is an automated cherry-pick of #11021

What problem does this PR solve?

Issue Number: close #11022

What is changed and how it works?

Pass cloned replicaConfig instead of lastInfo to the New method of sinkManager to ensure the sourceID is set correctly.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

ti-chi-bot avatar May 07 '24 05:05 ti-chi-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign leoppro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar May 07 '24 05:05 ti-chi-bot[bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify fcf0bea36f6e20772fa6ee4d656b966c958a9cbd link true /test verify
pull-cdc-integration-mysql-test fcf0bea36f6e20772fa6ee4d656b966c958a9cbd link true /test cdc-integration-mysql-test
pull-cdc-integration-pulsar-test fcf0bea36f6e20772fa6ee4d656b966c958a9cbd link true /test cdc-integration-pulsar-test
pull-cdc-integration-storage-test fcf0bea36f6e20772fa6ee4d656b966c958a9cbd link true /test cdc-integration-storage-test
pull-cdc-integration-kafka-test fcf0bea36f6e20772fa6ee4d656b966c958a9cbd link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar May 07 '24 05:05 ti-chi-bot[bot]