tiflow
tiflow copied to clipboard
pingcap
sink(ticdc): add ut case for open protocol
What problem does this PR solve?
Issue Number: close #11012
What is changed and how it works?
add ut case for open protocol to cover case when output-old-value is disabled and delete-only-output-handle-key-columns is enabled
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.5243%. Comparing base (
ba6db07) to head (ffee17a). Report is 70 commits behind head on master.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 64.4451% <100.0000%> (+2.7395%) |
:arrow_up: |
| dm | 52.6646% <ø> (+1.4118%) |
:arrow_up: |
| engine | 63.5518% <ø> (+0.1638%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 59.5243% <100.0000%> (+2.1100%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11013 +/- ##
================================================
+ Coverage 57.4142% 59.5243% +2.1100%
================================================
Files 851 861 +10
Lines 125225 133616 +8391
================================================
+ Hits 71897 79534 +7637
- Misses 47936 48612 +676
- Partials 5392 5470 +78
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 3AceShowHand, asddongmen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [3AceShowHand,asddongmen]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[LGTM Timeline notifier]
Timeline:
-
2024-04-30 06:37:17.754375997 +0000 UTC m=+339191.511511571: :ballot_box_with_check: agreed by asddongmen. -
2024-04-30 06:37:35.316652601 +0000 UTC m=+339209.073788159: :ballot_box_with_check: agreed by 3AceShowHand.
@sdojjy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-dm-integration-test | ffee17a6556cd8014ee7ddaf7b1fb62352f7d19b | link | unknown | /test dm-integration-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.