tiflow
tiflow copied to clipboard
pingcap
redo(ticdc): return internal error in redo writer
What problem does this PR solve?
Issue Number: close #10124
What is changed and how it works?
- return internal error in redo writer
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hongyunyan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hongyunyan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-05-08 06:19:26.753972583 +0000 UTC m=+1029320.511108157: :ballot_box_with_check: agreed by hongyunyan.
Codecov Report
Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 57.7633%. Comparing base (
ba6db07) to head (4d3c7ef). Report is 19 commits behind head on master.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 62.2676% <84.2105%> (+0.5620%) |
:arrow_up: |
| dm | 51.3811% <ø> (+0.1283%) |
:arrow_up: |
| engine | 63.4444% <ø> (+0.0564%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 57.7633% <84.2105%> (+0.3491%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #11011 +/- ##
================================================
+ Coverage 57.4142% 57.7633% +0.3491%
================================================
Files 851 851
Lines 125225 126350 +1125
================================================
+ Hits 71897 72984 +1087
- Misses 47936 47952 +16
- Partials 5392 5414 +22
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@CharlesCheung96: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cdc-integration-mysql-test | 4d3c7ef65638eadfa682b35120b84e8909d95396 | link | true | /test cdc-integration-mysql-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hongyunyan, sdojjy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hongyunyan,sdojjy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-05-08 06:19:26.753972583 +0000 UTC m=+1029320.511108157: :ballot_box_with_check: agreed by hongyunyan. -
2024-05-14 01:55:43.86685993 +0000 UTC m=+1531897.623995503: :ballot_box_with_check: agreed by sdojjy.
In response to a cherrypick label: new pull request created to branch release-7.5: #11090.
In response to a cherrypick label: new pull request created to branch release-6.5: #11091.
In response to a cherrypick label: new pull request created to branch release-7.1: #11092.
In response to a cherrypick label: new pull request created to branch release-8.1: #11093.