tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

Delete range less

Open hicqu opened this issue 10 months ago • 6 comments

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu avatar Apr 23 '24 09:04 hicqu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hicqu, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 23 '24 09:04 ti-chi-bot[bot]

Codecov Report

Attention: Patch coverage is 55.76923% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 57.3740%. Comparing base (566c77c) to head (4fab9cb). Report is 2 commits behind head on master.

:exclamation: Current head 4fab9cb differs from pull request most recent head af4062a. Consider uploading reports for the commit af4062a to get more accurate results

Additional details and impacted files
Components Coverage Δ
cdc 61.6222% <55.7692%> (+0.0229%) :arrow_up:
dm 51.2234% <ø> (+0.0080%) :arrow_up:
engine 63.3950% <ø> (+0.0070%) :arrow_up:
Flag Coverage Δ
unit 57.3740% <55.7692%> (+0.0136%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10953        +/-   ##
================================================
+ Coverage   57.3604%   57.3740%   +0.0136%     
================================================
  Files           851        851                
  Lines        125590     125548        -42     
================================================
- Hits          72039      72032         -7     
+ Misses        48130      48101        -29     
+ Partials       5421       5415         -6     

codecov[bot] avatar May 06 '24 07:05 codecov[bot]

/retest

hicqu avatar May 08 '24 10:05 hicqu

/test cdc-integration-storage-test

hicqu avatar May 08 '24 14:05 hicqu

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

:open_book: For more info, you can check the "Contribute Code" section in the development guide.

ti-chi-bot[bot] avatar May 09 '24 04:05 ti-chi-bot[bot]

@hicqu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify dd8f606a1642009086c30e71bcb527b1a62c957c link true /test verify
pull-cdc-integration-kafka-test dd8f606a1642009086c30e71bcb527b1a62c957c link true /test cdc-integration-kafka-test
pull-cdc-integration-storage-test dd8f606a1642009086c30e71bcb527b1a62c957c link true /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar May 09 '24 05:05 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Jul 05 '24 22:07 ti-chi-bot[bot]