tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

redo(ticdc): return ErrStorageInitialize if the external storage initialization fails (#10745)

Open ti-chi-bot opened this issue 10 months ago • 2 comments

This is an automated cherry-pick of #10745

What problem does this PR solve?

Issue Number: close #10710

What is changed and how it works?

  • return ErrStorageInitialize if the external storage initialization fails
  • Use a smaller DefaultTimeout, since changefeed will be restart when meet error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

ti-chi-bot avatar Apr 03 '24 04:04 ti-chi-bot

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 03 '24 04:04 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Apr 11 '24 09:04 ti-chi-bot[bot]

/retest

CharlesCheung96 avatar May 20 '24 09:05 CharlesCheung96