tiflow
tiflow copied to clipboard
test(ticdc): update integration-test-binaries download
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.
If you don't think this PR needs a release note then fill it with `None`.
Welcome @wk989898!
It looks like this is your first PR to pingcap/tiflow 🎉.
I'm the bot to help you request reviewers, add labels and more, See available commands.
We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to pingcap/tiflow. :smiley:
Hi @wk989898. Thanks for your PR.
I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test all
Please fill your PR description, you can reference to a merged PR in this repo.
Codecov Report
Merging #10746 (4351842) into master (12a184e) will increase coverage by
0.0297%
. Report is 19 commits behind head on master. The diff coverage isn/a
.
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.9105% <ø> (+0.0140%) |
:arrow_up: |
dm | 51.2656% <ø> (+0.0444%) |
:arrow_up: |
engine | 63.4020% <ø> (+0.0296%) |
:arrow_up: |
Flag | Coverage Δ | |
---|---|---|
unit | 57.5782% <ø> (+0.0297%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10746 +/- ##
================================================
+ Coverage 57.5485% 57.5782% +0.0297%
================================================
Files 853 853
Lines 126886 126949 +63
================================================
+ Hits 73021 73095 +74
+ Misses 48427 48421 -6
+ Partials 5438 5433 -5
Please create a new issue to describe the problem this PR addressing. And then use "close: #xxx" to link to it. Also please describe how you address the issue in the What is changed and how it works?
section
[FORMAT CHECKER NOTIFICATION]
Notice: To remove the do-not-merge/needs-linked-issue
label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123
or Issue Number: ref #456
.
:open_book: For more info, you can check the "Contribute Code" section in the development guide.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: CharlesCheung96, sdojjy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [CharlesCheung96,sdojjy]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[LGTM Timeline notifier]
Timeline:
-
2024-03-18 10:33:14.24847609 +0000 UTC m=+1286421.270722478
: :ballot_box_with_check: agreed by CharlesCheung96. -
2024-03-27 08:40:07.529544936 +0000 UTC m=+2057234.551791323
: :ballot_box_with_check: agreed by sdojjy.
/retest