tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

redo(ticdc): return ErrStorageInitialize if the external storage initialization fails

Open CharlesCheung96 opened this issue 11 months ago • 5 comments

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

  • return ErrStorageInitialize if the external storage initialization fails
  • Use a smaller DefaultTimeout, since changefeed will be restart when meet error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

CharlesCheung96 avatar Mar 08 '24 09:03 CharlesCheung96

Codecov Report

Merging #10745 (d7a1ab7) into master (e5edb19) will increase coverage by 0.2832%. Report is 15 commits behind head on master. The diff coverage is 0.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 62.3249% <0.0000%> (+0.4004%) :arrow_up:
dm 51.4216% <ø> (+0.1801%) :arrow_up:
engine 63.4218% <ø> (+0.0282%) :arrow_up:
Flag Coverage Δ
unit 57.8526% <0.0000%> (+0.2832%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10745        +/-   ##
================================================
+ Coverage   57.5694%   57.8526%   +0.2832%     
================================================
  Files           851        853         +2     
  Lines        126793     127517       +724     
================================================
+ Hits          72994      73772       +778     
+ Misses        48361      48311        -50     
+ Partials       5438       5434         -4     

codecov[bot] avatar Mar 08 '24 09:03 codecov[bot]

/retest

CharlesCheung96 avatar Mar 10 '24 13:03 CharlesCheung96

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [hongyunyan,sdojjy]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 14 '24 03:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 10:19:51.902690715 +0000 UTC m=+421618.924937103: :ballot_box_with_check: agreed by sdojjy.
  • 2024-03-14 03:45:30.590049784 +0000 UTC m=+916357.612296171: :ballot_box_with_check: agreed by hongyunyan.

ti-chi-bot[bot] avatar Mar 14 '24 03:03 ti-chi-bot[bot]

/retest

CharlesCheung96 avatar Mar 16 '24 13:03 CharlesCheung96

In response to a cherrypick label: new pull request created to branch release-6.5: #10844.

ti-chi-bot avatar Mar 25 '24 07:03 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.1: #10876.

ti-chi-bot avatar Apr 03 '24 04:04 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-7.5: #10877.

ti-chi-bot avatar Apr 03 '24 04:04 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.1: #11147.

ti-chi-bot avatar May 20 '24 09:05 ti-chi-bot