tiflow
tiflow copied to clipboard
test: add a case of Mariadb for dm_upstream_switch
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflow/issues/10734, close https://github.com/pingcap/tiflow/issues/10733
What is changed and how it works?
- Add DM_MASTER_EXTRA_ARG to dm_upstream_switch case
- Add Mariadb dm_upstream_switch case(copy from MySQL&&fix some compatible problems)
- FYI, Mariadb vs MySQL in gtid replication
- need set
gtid_domain_id
- gtid mode is
gtid_strict_mode
- change master to need set
master_use_gtid=slave_pos
- need set
Check List
Tests
- Integration test, https://github.com/okJiang/tiflow/actions/runs/8182319412
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from okjiang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
Merging #10735 (4095590) into master (f9ca8a2) will increase coverage by
0.0053%
. Report is 2 commits behind head on master. The diff coverage isn/a
.
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.9406% <ø> (+0.0174%) |
:arrow_up: |
dm | 51.1950% <ø> (+0.0080%) |
:arrow_up: |
engine | 63.2805% <ø> (-0.0636%) |
:arrow_down: |
Flag | Coverage Δ | |
---|---|---|
unit | 57.5465% <ø> (+0.0053%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10735 +/- ##
================================================
+ Coverage 57.5412% 57.5465% +0.0053%
================================================
Files 850 851 +1
Lines 126770 126793 +23
================================================
+ Hits 72945 72965 +20
Misses 48384 48384
- Partials 5441 5444 +3
/retest
can we combine it with upstream_swith? e.g. we only need add mariadb pod in original docker file, and add new case in original case.sh
Solving this problem https://github.com/pingcap/tiflow/issues/10741 later may require modifying the case. If there is no need to modify it, I will merge it together.
/retest