cli(ticdc): fix create changefeed failure when `enable-old-value` is set to true
What problem does this PR solve?
Issue Number: close #10711
What is changed and how it works?
Report a warning and ignore the config when enable-old-value is set to true.
Check List
Tests
- Manual test (add detailed scripts or steps below)
- create changefeed with config file which set
enable-old-valueto true and see whether changefeed can be created successfully and whether the warning is printed as expected.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign 3aceshowhand for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label needs-cherry-pick-release-7.5
Codecov Report
Merging #10731 (23ac6ec) into master (f9ca8a2) will increase coverage by
0.0302%. Report is 2 commits behind head on master. The diff coverage is100.0000%.
Additional details and impacted files
| Components | Coverage Δ | |
|---|---|---|
| cdc | 61.9475% <100.0000%> (+0.0243%) |
:arrow_up: |
| dm | 51.2273% <ø> (+0.0404%) |
:arrow_up: |
| engine | 63.3582% <ø> (+0.0141%) |
:arrow_up: |
| Flag | Coverage Δ | |
|---|---|---|
| unit | 57.5714% <100.0000%> (+0.0302%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10731 +/- ##
================================================
+ Coverage 57.5412% 57.5714% +0.0302%
================================================
Files 850 851 +1
Lines 126770 126799 +29
================================================
+ Hits 72945 73000 +55
+ Misses 48384 48363 -21
+ Partials 5441 5436 -5
/test cdc-integration-kafka-test
The same issue has been address by this issue https://github.com/pingcap/tiflow/issues/10916. Closing this PR.