tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

sink(ticdc): adjust lag bucket and add metrics for sink flush lag (#10596)

Open ti-chi-bot opened this issue 1 year ago • 2 comments

This is an automated cherry-pick of #10596

What problem does this PR solve?

Issue Number: close #10675

What is changed and how it works?

Adjust the lag bucket of related metrics like ticdc_owner_checkpoint_lag_histogram.

Add a new metric ticdc_sink_flush_lag_histogram to monitor the per event flush lag calculated by ts_after_event_flushed_to_downstream - commit_ts_of_event image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

ti-chi-bot avatar Mar 06 '24 11:03 ti-chi-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 18 '24 02:03 ti-chi-bot[bot]

/test pull-dm-integration-test

lidezhu avatar Mar 18 '24 03:03 lidezhu

@lidezhu: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run all jobs.

In response to this:

/test pull-dm-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 18 '24 03:03 ti-chi-bot[bot]

/test dm-integration-test

lidezhu avatar Mar 18 '24 03:03 lidezhu

/test dm-integration-test

lidezhu avatar Mar 18 '24 03:03 lidezhu