tiflow
tiflow copied to clipboard
reduce table level logs for module kv-client
What problem does this PR solve?
Issue Number: ref #10486
What is changed and how it works?
There is still a table level log starts to check locked regions
. If there are lots of tables, the log will be print too frequently.
This PR disables the log by default. However, it's still enabled for SharedClient
, because it's a changefeed level log in SharedClient
.
Check List
Tests
- No code
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None
Codecov Report
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 57.5732%. Comparing base (
25ce29c
) to head (35b7872
). Report is 179 commits behind head on master.
Additional details and impacted files
Components | Coverage Δ | |
---|---|---|
cdc | 61.9941% <0.0000%> (-0.0325%) |
:arrow_down: |
dm | 51.1732% <ø> (-0.0486%) |
:arrow_down: |
engine | 63.3813% <ø> (-0.0142%) |
:arrow_down: |
Flag | Coverage Δ | |
---|---|---|
unit | 57.5732% <0.0000%> (-0.0364%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@@ Coverage Diff @@
## master #10666 +/- ##
================================================
- Coverage 57.6095% 57.5732% -0.0364%
================================================
Files 849 849
Lines 126689 126689
================================================
- Hits 72985 72939 -46
- Misses 48242 48285 +43
- Partials 5462 5465 +3
/test
@hicqu: The /test
command needs one or more targets.
The following commands are available to trigger required jobs:
-
/test cdc-integration-kafka-test
-
/test cdc-integration-mysql-test
-
/test cdc-integration-pulsar-test
-
/test cdc-integration-storage-test
-
/test dm-compatibility-test
-
/test dm-integration-test
-
/test engine-integration-test
-
/test verify
-
/test wip-pull-build
-
/test wip-pull-check
-
/test wip-pull-unit-test-cdc
-
/test wip-pull-unit-test-dm
-
/test wip-pull-unit-test-engine
Use /test all
to run the following jobs that were automatically triggered:
-
pingcap/tiflow/ghpr_verify
-
pingcap/tiflow/pull_cdc_integration_kafka_test
-
pingcap/tiflow/pull_cdc_integration_pulsar_test
-
pingcap/tiflow/pull_cdc_integration_storage_test
-
pingcap/tiflow/pull_cdc_integration_test
-
pingcap/tiflow/pull_dm_compatibility_test
-
pingcap/tiflow/pull_dm_integration_test
-
pingcap/tiflow/pull_engine_integration_test
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest
@hicqu: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-cdc-integration-kafka-test | 35b7872228cdba7d0cef3cb34bd2c0dfed2cd7be | link | true | /test cdc-integration-kafka-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[LGTM Timeline notifier]
Timeline:
-
2024-03-06 12:52:52.537414744 +0000 UTC m=+257999.559661131
: :ballot_box_with_check: agreed by asddongmen.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asddongmen
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [asddongmen]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.