tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

reduce table level logs for module kv-client

Open hicqu opened this issue 1 year ago • 8 comments

What problem does this PR solve?

Issue Number: ref #10486

What is changed and how it works?

There is still a table level log starts to check locked regions. If there are lots of tables, the log will be print too frequently.

This PR disables the log by default. However, it's still enabled for SharedClient, because it's a changefeed level log in SharedClient.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu avatar Feb 28 '24 08:02 hicqu

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.5732%. Comparing base (25ce29c) to head (35b7872). Report is 179 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.9941% <0.0000%> (-0.0325%) :arrow_down:
dm 51.1732% <ø> (-0.0486%) :arrow_down:
engine 63.3813% <ø> (-0.0142%) :arrow_down:
Flag Coverage Δ
unit 57.5732% <0.0000%> (-0.0364%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10666        +/-   ##
================================================
- Coverage   57.6095%   57.5732%   -0.0364%     
================================================
  Files           849        849                
  Lines        126689     126689                
================================================
- Hits          72985      72939        -46     
- Misses        48242      48285        +43     
- Partials       5462       5465         +3     

codecov[bot] avatar Feb 28 '24 08:02 codecov[bot]

/test

hicqu avatar Mar 06 '24 04:03 hicqu

@hicqu: The /test command needs one or more targets. The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify
  • /test wip-pull-build
  • /test wip-pull-check
  • /test wip-pull-unit-test-cdc
  • /test wip-pull-unit-test-dm
  • /test wip-pull-unit-test-engine

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify
  • pingcap/tiflow/pull_cdc_integration_kafka_test
  • pingcap/tiflow/pull_cdc_integration_pulsar_test
  • pingcap/tiflow/pull_cdc_integration_storage_test
  • pingcap/tiflow/pull_cdc_integration_test
  • pingcap/tiflow/pull_dm_compatibility_test
  • pingcap/tiflow/pull_dm_integration_test
  • pingcap/tiflow/pull_engine_integration_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Mar 06 '24 04:03 ti-chi-bot[bot]

/retest

hicqu avatar Mar 06 '24 04:03 hicqu

@hicqu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-kafka-test 35b7872228cdba7d0cef3cb34bd2c0dfed2cd7be link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Mar 06 '24 05:03 ti-chi-bot[bot]

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 12:52:52.537414744 +0000 UTC m=+257999.559661131: :ballot_box_with_check: agreed by asddongmen.

ti-chi-bot[bot] avatar Mar 06 '24 12:03 ti-chi-bot[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Mar 06 '24 12:03 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Apr 01 '24 08:04 ti-chi-bot[bot]