tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

codecov: make project coverage status informational

Open purelind opened this issue 1 year ago • 3 comments

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/10473

What is changed and how it works?

To make the codecov status of project just informational in github commit statuses on components and flags level, not fail the commit statuses.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • [x] No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

purelind avatar Feb 27 '24 02:02 purelind

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign suzaku for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Feb 27 '24 02:02 ti-chi-bot[bot]

/retest

purelind avatar Mar 15 '24 08:03 purelind

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.5255%. Comparing base (833943f) to head (914e375). Report is 102 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.8655% <ø> (-0.0928%) :arrow_down:
dm 51.2192% <ø> (-0.0187%) :arrow_down:
engine 63.2570% <ø> (-0.1597%) :arrow_down:
Flag Coverage Δ
unit 57.5255% <ø> (-0.0602%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10651        +/-   ##
================================================
- Coverage   57.5856%   57.5255%   -0.0602%     
================================================
  Files           849        853         +4     
  Lines        126707     127008       +301     
================================================
+ Hits          72965      73062        +97     
- Misses        48279      48498       +219     
+ Partials       5463       5448        -15     

codecov[bot] avatar Mar 15 '24 08:03 codecov[bot]