tiflow icon indicating copy to clipboard operation
tiflow copied to clipboard

puller(cdc): simplify puller internal code

Open hicqu opened this issue 1 year ago • 4 comments

What problem does this PR solve?

Issue Number: close #10574

What is changed and how it works?

After #10506 is merged, puller module just receives events and table ResolvedTs and then dispatches them. So we can move action into kv-client so that goroutines of puller can be removed totally.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu avatar Jan 31 '24 14:01 hicqu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hicqu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot[bot] avatar Jan 31 '24 14:01 ti-chi-bot[bot]

/retest

hicqu avatar Feb 05 '24 04:02 hicqu

@hicqu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify f4c98651e10273b9b5ce16b85dbbf68ba933d695 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot[bot] avatar Feb 05 '24 04:02 ti-chi-bot[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot[bot] avatar Feb 13 '24 20:02 ti-chi-bot[bot]